good sam benefits vs. cons

As I learned in another post, Good Sam is not friendly to veterans so it's not worth it to me and I won't be renewing.

There are multiple parts of it.
If you want to join for CW discounts and possible 10% at campgrounds that's up to your usage, other organizations offer buying/camping discounts too. Escapees, Passport America, etc. Its on you to figure out which ones are the best for your type of areas and usage.
If your looking at roadside assist, check your dealer first, some offer a free year of GS or Coachnet when you buy, and again if you are buying, read the fine print to see how many exclusions each will have.

Read the brochure to see if there is a benefit for you. For me, the little discount at commercial campgrounds is the only thing I would use and even that rarely. So, I don't waste my money. Besides the whole organization is not customer friendly.