RPBD or reduced pressure backflow device is what public buildings use to keep their water from returning into the city water. Also used in many medical/dental facilities on equipment to keep contaminated water at the source and not into the building.
I have/had as pictured atmospheric vacuum breakers that are designed as shown to keep water from returning from the tank to the public water supply. By design yes they will keep odors on the tank side. Not really designed for that but yes they will.
Mine started leaking so I removed BOTH and installed PVC fittings in their place. I have my waterline connected to the two flush lines at all times with a "Y" that has 1/4 turn valves. I open and close the valves as needed. I used the sprayer hose as the water supply, I never have to connect of disconnect anything when flushing. I have a timer on my phone set each time so I don't overfill the tank.
Technically this is not "LEGAL" but it sure works well. If I sell the RV the new owner will be informed to the condition so they can make an informed decision to return to stock or not.