I have always had the Atwood water heater in my rigs.
First was a pilot model and the last two have been the DSI model.
I prefer the Atwood aluminum tank over the Suburban glass lined steel tank.
Most of the problems people have with water heaters is lack of maintenance.
The burners need to be cleaned, electrical connections cleaned and treated with electrical grease.
The ECO and thermostat need to be tight against the tank.
There is a thermal fuse normally hidden behind a piece of tubing near the ECO/thermostat. These can create problems. sometimes they go open intermittently.
DSI electrical connection behind the gas valve gets corroded and will not activate the gas valve.
The circuit board from Dinosaur electronics should be around $100 if needed.
dinosaur electronicsFactory boards are not worth the extra dollars.