ANY "club" is only worthwhile IF you use the benefits.
I used to belong to Good Sam. Then I realized that I very rarely stayed in a "Good SamPark", bought very few parts from a Good Sam affiliated dealer, and just didn't take advantage of any of the benefits. I really did not enjoy the magazine, either.
So, I let that membership lapse.
then, when planning a trip to Chattanooga, I signed up for the KOA club, at the recommendation of the KOA where I was going to spend a week, near Ringgold, GA. The discount more than made up for the membership cost. Since then, I have not stayed in a KOA, not even once. So, that membership went away also.
Now, the only such "membership" I have is a Golden Age Passport. It is free, and only works at Federal campgrounds; that is where most of our camping is done anyway!