I think your choices are both viable, so it really falls on your personal likes/dislikes.
we like our diesel pusher and would look for one slightly bigger (more slide outs) if we went full time. but we recently got a pickup for our toad because we want to take a golf cart with us. I see you have a "toy" you'd like to take, too.
I don't know how long trailers last compared to motorhomes, but I'd guess a lot depends on your regular maintenance.
Probably, you can take a toy hauler places you cannot or should not take a motorhome. Some boondocking places have pretty rough access roads sometimes.
Finally, the only critical thing for me in a trailer is that I can use it with or without the slides out.