if you want more developed private campgrounds PA can be a good deal. If your looking at state parks, county parks, FS parks and more undeveloped campgrounds, it may not be worth the cost. We usually stay at state/county/FS parks or remote sites and PA was basically a wash for us over a couple of years. But mostly because of where we like to camp. and in some cases the discount didn't apply during the times we wanted to camp.
Good sam is worth the investment IMHO, since most any private cg gives a good sam discount. Also AARP, AAA or Sr. status will often get you a discount.
It's hard to beat a $5/night cost at a FS campground with the America the Beautiful Sr. pass!