I went with these combination storage locks about 8 years ago.
Combination Locks on Amazoni've never looked back and haven't had any issues with them spinning.
If your existing locks are spinning, the nut on the back has come loose and you're going to need some sort of washer to stop it from spinning.
The cam locks above don't come with washers - so you're going to need to find them online (e.g. McMaster-Carr)
I went with the dark finished locks as the chrome/polished finished ones are harder to read.
(black with white numbers is easier to read at night)
in the 8 years I've had the combo locks, i've never had a problem with them not working well. I've found that the metal behind the lock has gotten bent when DW doesn't full open the lock and the metal of the lock strikes the lip on the inside... but that's operator error not a defect of the lock itself.