Solar panels & controller - am I missing anything?

Read the instructions closely on the controller. You're going to need some circuit protection and shutoff ability. A CB near the batteries, one on each side of the controller if the wire run is long, and perhaps one near the panel if you are going to permanently locate it and the wiring is to be hidden. CB's can be used to shut off the power for maintenance, even though I don't think they meet the letter of the code.