I recently bought a Tesla and think that it is a good for the environment but recognize that it even though it is a simple question the answer is very complex. Also, the technology is still moving very quickly. Tesla has already engineered so many metal out of their batteries that it is difficult for recyclers to make any profit by recycling them. Of course, that technology is advancing too.
Another big factor for EVs is where the power originates. It seems like nearly every day I read an article about a new breakthrough with solar panels, windmills, nuclear fission modular reactors and even nuclear fusion. Meanwhile, even if all we do is move the pollution source and waste heat away from where people are to somewhere they are not we have at least made cities more comfortable and healthier to live in. Reclaimed batteries from wrecked EVs are helping make solar systems more affordable people building their own home systems. That is the best form of recycling.