Using bleach to clean water tanks

We had to do a bleach treatment a couple of weeks ago. The last time I used water in the rig was when I replaced the water pump late May. The hot water tank had some stank to it. Not a little bit of stink, but some stank! Drained the hot water tank, added an entire bottle of bleach to a half full fresh water hold and then turned on the pump to refill the hot water. A couple of hours later, drained the hot water tank again, turned back on the city water faucet and refilled the hot water with fresh city water. No longer any foul smell with the hot water.